Skip to content

Conversation

@stefannikolei
Copy link
Contributor

@stefannikolei stefannikolei commented Oct 28, 2025

I opened your PR in Rider and got many errors

Fixed those:

  • Target type new
  • Collection Expressions
  • Usage of var

- Target type new
- Collection Expressions
- ...
@stefannikolei
Copy link
Contributor Author

stefannikolei commented Oct 28, 2025

@JimBobSquarePants Was VS silent about those things?

Perhaps adding <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild> to Directory.Build.props will make VS to show the errors too?

@JimBobSquarePants
Copy link
Member

That’s interesting… There were warnings but nothing blocking. I didn’t want to change things I didn’t need to yet to avoid conflicts with #342

@stefannikolei
Copy link
Contributor Author

Those errors are not blocking in rider.
But everything is just red 🫣

@stefannikolei
Copy link
Contributor Author

That’s interesting… There were warnings but nothing blocking. I didn’t want to change things I didn’t need to yet to avoid conflicts with #342

I can understand that. I will have a look at the VS configuration and see why Rider and VS show totally different "Errors"..

@stefannikolei
Copy link
Contributor Author

VS does not really enforce the CodeStyle we have configured.

This can only be enforced through adding 'true ' to Directory.Build.props or in the csproj direct.

You can try it out if you want to see some red ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants